Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ni-python-styleguide treats ni_measurementlink_service as 3rd party for projects that copied Examples' helpers #374

Closed
kirstyong opened this issue Sep 14, 2023 · 0 comments · Fixed by #443
Assignees
Labels
bug Something isn't working

Comments

@kirstyong
Copy link

kirstyong commented Sep 14, 2023

Bug Report

Running ni-python-styleguide lint on poetry projects that have copied the helpers files and teststand_fixture.py to use will treat ni-measurementlink-service incorrectly as 3rd party when organizing imports. Example of changes the ni styleguide wants to make on the daqmx helpers and the teststand_fixture.py.

image

Repro or Code Sample

You can run ni-python-styleguide lint on any of the projects from this repo to see the suggested changes on the helpers and teststand_fixture.py. See the errors from this pipeline run.

Expected Behavior

Anyone using a copied helpers or teststand_fixture.py shouldn't run into any suggested lint changes if they also follow ni-python-styleguide.

Current Behavior

ni-measurementlink-service is being prompted to be organized as a 3rd party import.

Possible Solution

This was already addressed for ni_measurementlink_generator but not for the examples

Context

The Test Workflow team copied the helpers files from the 2023 Q3 Examples and when running the pipeline that includes the ni-python-styleguide check, we fail that step because it thinks the driver helpers and teststand_fixture.py need changes.

Your Environment

  • Windows 10
  • ni-measurementlink-service version 2023 Q3
  • MeasurementLink version 2023 Q3
  • Python version 3.9

AB#2522357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants