You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running ni-python-styleguide lint on poetry projects that have copied the helpers files and teststand_fixture.py to use will treat ni-measurementlink-service incorrectly as 3rd party when organizing imports. Example of changes the ni styleguide wants to make on the daqmx helpers and the teststand_fixture.py.
Repro or Code Sample
You can run ni-python-styleguide lint on any of the projects from this repo to see the suggested changes on the helpers and teststand_fixture.py. See the errors from this pipeline run.
Expected Behavior
Anyone using a copied helpers or teststand_fixture.py shouldn't run into any suggested lint changes if they also follow ni-python-styleguide.
Current Behavior
ni-measurementlink-service is being prompted to be organized as a 3rd party import.
Possible Solution
This was already addressed for ni_measurementlink_generator but not for the examples
Context
The Test Workflow team copied the helpers files from the 2023 Q3 Examples and when running the pipeline that includes the ni-python-styleguide check, we fail that step because it thinks the driver helpers and teststand_fixture.py need changes.
Bug Report
Running
ni-python-styleguide lint
on poetry projects that have copied the helpers files and teststand_fixture.py to use will treat ni-measurementlink-service incorrectly as 3rd party when organizing imports. Example of changes the ni styleguide wants to make on the daqmx helpers and the teststand_fixture.py.Repro or Code Sample
You can run
ni-python-styleguide lint
on any of the projects from this repo to see the suggested changes on the helpers and teststand_fixture.py. See the errors from this pipeline run.Expected Behavior
Anyone using a copied helpers or teststand_fixture.py shouldn't run into any suggested lint changes if they also follow ni-python-styleguide.
Current Behavior
ni-measurementlink-service is being prompted to be organized as a 3rd party import.
Possible Solution
This was already addressed for ni_measurementlink_generator but not for the examples
Context
The Test Workflow team copied the helpers files from the 2023 Q3 Examples and when running the pipeline that includes the ni-python-styleguide check, we fail that step because it thinks the driver helpers and teststand_fixture.py need changes.
Your Environment
ni-measurementlink-service
version 2023 Q3AB#2522357
The text was updated successfully, but these errors were encountered: