Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle types and daqmx versions #102

Closed
creilly opened this issue Jun 16, 2020 · 0 comments · Fixed by #148
Closed

handle types and daqmx versions #102

creilly opened this issue Jun 16, 2020 · 0 comments · Fixed by #148

Comments

@creilly
Copy link

creilly commented Jun 16, 2020

nidaqmx-python/nidaqmx/_lib.py

Line 242 in 0058a02

if version.major_version <= 8 and version.minor_version <= 8:

Won't this line return the wrong handle type for, say, version 7.9?

I believe you want:
c_uint if (majorversion < 8 or (majorversion == 8 and minorversion <= 8)) else c_void_p
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix version checking logic zhindes/nidaqmx-python
1 participant
@creilly