-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make DataFrame and Spec clients compatible with SystemLink Client http configuration #61
Merged
spanglerco
merged 6 commits into
master
from
users/sramaraj/jupyter-support-http-cfg-manager
Jun 18, 2024
Merged
feat: Make DataFrame and Spec clients compatible with SystemLink Client http configuration #61
spanglerco
merged 6 commits into
master
from
users/sramaraj/jupyter-support-http-cfg-manager
Jun 18, 2024
+48
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfiguration Manager
spanglerco
requested changes
Jun 13, 2024
…e and spec clients
spanglerco
approved these changes
Jun 14, 2024
mure
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
spanglerco
approved these changes
Jun 18, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add
JupyterHttpConfiguration
as a fallback configuration for theHttpConfigurationManager
. Allows the Clients to authenticate agnostic of the environment they're run from.Why should this Pull Request be merged?
Enables SystemLink clients to adapt to supported run environments when using the default value for
configuration
arg likeclient = DataFrameClient()
What testing has been done?
Manual testing
KeyError
occurs becauseJupyterHttpConfiguration
is not available outside SLEDataFrameClient()
to usecore.HttpConfigurationManager.get_configuration()
as the default configurationKeyError
signifying that the client was created using the SystemLink client's HTTP Credentials