Skip to content

Commit 237ec7b

Browse files
Merge #927
927: Enable the select tests on powerpc and mips r=asomers a=jonas-schievink They pass at least on my machine with QEMU, so the underlying bugs might have been fixed. Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2 parents c1ee0d0 + b572415 commit 237ec7b

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

src/sys/select.rs

-9
Original file line numberDiff line numberDiff line change
@@ -273,14 +273,7 @@ mod tests {
273273
assert_eq!(set.highest(), Some(7));
274274
}
275275

276-
// powerpc-unknown-linux-gnu currently fails on the first `assert_eq` because
277-
// `select()` returns a 0 instead of a 1. Since this test has only been run on
278-
// qemu, it's unclear if this is a OS or qemu bug. Just disable it on that arch
279-
// for now.
280-
// FIXME: Fix tests for powerpc and mips
281-
// FIXME: Add a link to an upstream qemu bug if there is one
282276
#[test]
283-
#[cfg_attr(any(target_arch = "powerpc", target_arch = "mips"), ignore)]
284277
fn test_select() {
285278
let (r1, w1) = pipe().unwrap();
286279
write(w1, b"hi!").unwrap();
@@ -301,7 +294,6 @@ mod tests {
301294
}
302295

303296
#[test]
304-
#[cfg_attr(any(target_arch = "powerpc", target_arch = "mips"), ignore)]
305297
fn test_select_nfds() {
306298
let (r1, w1) = pipe().unwrap();
307299
write(w1, b"hi!").unwrap();
@@ -322,7 +314,6 @@ mod tests {
322314
}
323315

324316
#[test]
325-
#[cfg_attr(any(target_arch = "powerpc", target_arch = "mips"), ignore)]
326317
fn test_select_nfds2() {
327318
let (r1, w1) = pipe().unwrap();
328319
write(w1, b"hi!").unwrap();

0 commit comments

Comments
 (0)