Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sharktank] Refactor naming of BaseLayer #1168

Open
sogartar opened this issue Mar 26, 2025 · 0 comments
Open

[sharktank] Refactor naming of BaseLayer #1168

sogartar opened this issue Mar 26, 2025 · 0 comments

Comments

@sogartar
Copy link
Contributor

In a recent PR some discussions #1013 (comment) #1013 (comment) arose that touch on the maybe confusing naming of the BaseLayer class. Which is the base of all our models and layers. It probably should be called sharktank.Module. This holds for ThetaLayer as well.
@sogartar sogartar changed the title [sharktank] Refactor naming of layer and model/module [sharktank] Refactor naming of BaseLayer Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sogartar