Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate additional package on top of node-addon-api? #363

Closed
mhdawson opened this issue Mar 4, 2019 · 6 comments · Fixed by nodejs/node-addon-api#477
Closed

Separate additional package on top of node-addon-api? #363

mhdawson opened this issue Mar 4, 2019 · 6 comments · Fixed by nodejs/node-addon-api#477
Assignees
Milestone

Comments

@mhdawson
Copy link
Member

mhdawson commented Mar 4, 2019

Do we need an additional module for extentions to node-addon-api?

For example: nodejs/node-addon-api#377

@mhdawson
Copy link
Member Author

mhdawson commented Mar 4, 2019

Also nodejs/node-addon-api#439 with part of the context.

Created this issue and added to Milestone 11 so that we review/discuss in the next N-API team meeting.

@mhdawson
Copy link
Member Author

mhdawson commented Mar 5, 2019

Another one that might be in helper or N-API itself: nodejs/node-addon-api#265

@mhdawson
Copy link
Member Author

From discussion 2 approaches would be:

  • node-addon-api is limited to

    • wrappers of N-API functions
    • utilities for which we can demonstrate strong benefits for being in node-addon-api versus a module
      and we encourage and support ecosystem modules as the starting
  • We are relatively liberal in terms of what we take into node-addon-api.

@mhdawson
Copy link
Member Author

mhdawson commented Mar 11, 2019

Next steps:

  • @digitalinfinity will take a first cut at expanding on the 2 approaches
  • document our preferred approach as PR to node-addon-api (@digitalinfinity will do that)
  • get input from those who have submitted the two PRs above
  • get input from other N-API users.

@digitalinfinity
Copy link
Contributor

Here's a first cut on a doc that expands on the problem being covered in this issue and possible solutions: https://docs.google.com/document/d/13DqZUeLjwf09EmkRBBIJkLE2bxmqWt2zF5FoNvHbjZc/edit?usp=sharing

@mhdawson
Copy link
Member Author

PR landed here: nodejs/node-addon-api#477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants