Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

body-praser broken on node.js master #74

Closed
MylesBorins opened this issue Feb 3, 2016 · 4 comments
Closed

body-praser broken on node.js master #74

MylesBorins opened this issue Feb 3, 2016 · 4 comments

Comments

@MylesBorins
Copy link
Contributor

It is fine on v5

  176 passing (494ms)
  1 failing

  1) bodyParser.urlencoded() with parameterLimit option with extended: false should work with Infinity limit:

      AssertionError: 0 == 10000
      + expected - actual

      -0
      +10000

      at test/urlencoded.js:666:12
      at Test._assertFunction (node_modules/supertest/lib/test.js:247:11)
      at Test.assert (node_modules/supertest/lib/test.js:148:18)
      at Server.assert (node_modules/supertest/lib/test.js:127:12)
      at emitCloseNT (net.js:1525:8)
@MylesBorins
Copy link
Contributor Author

looks like it has to do with a change in query-string

@MylesBorins
Copy link
Contributor Author

Broken in this PR
nodejs/node#2288
By This Commit
nodejs/node@27def4f

Reverting this commit on master allows the test suite for body-parser to work

@MylesBorins
Copy link
Contributor Author

Issue on body-parser https://github.com/expressjs/body-parser/issues/155

@MylesBorins
Copy link
Contributor Author

Fixed by nodejs/node@878bcd4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant