We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent 8282f01 commit cc5838cCopy full SHA for cc5838c
pylib/gyp/generator/msvs.py
@@ -3412,7 +3412,11 @@ def _FinalizeMSBuildSettings(spec, configuration):
3412
)
3413
# Turn on precompiled headers if appropriate.
3414
if precompiled_header:
3415
- precompiled_header = os.path.split(precompiled_header)[1]
+ # While MSVC works with just file name eg. "v8_pch.h", ClangCL requires
3416
+ # the full path eg. "tools/msvs/pch/v8_pch.h" to find the file.
3417
+ # P.S. Only ClangCL defines msbuild_toolset, for MSVC it is None.
3418
+ if configuration.get("msbuild_toolset") != 'ClangCL':
3419
+ precompiled_header = os.path.split(precompiled_header)[1]
3420
_ToolAppend(msbuild_settings, "ClCompile", "PrecompiledHeader", "Use")
3421
_ToolAppend(
3422
msbuild_settings, "ClCompile", "PrecompiledHeaderFile", precompiled_header
0 commit comments