Skip to content

Commit f2c7618

Browse files
authored
fix(msvs): correctly rename object files for absolute paths (#71)
1 parent 76bbca6 commit f2c7618

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
66

77
## [Unreleased]
88

9+
### Fixed
10+
- Correctly rename object files for absolute paths in MSVS generator.
11+
912
## [0.6.0] - 2020-10-13
1013

1114
### Added

pylib/gyp/generator/msvs.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -3618,9 +3618,11 @@ def _AddSources2(
36183618
# Always add an <ObjectFileName> value to support duplicate
36193619
# source file basenames.
36203620
file_name = os.path.splitext(source)[0] + ".obj"
3621-
if (file_name.startswith("..\\")):
3621+
if os.path.isabs(file_name):
3622+
file_name = os.path.splitdrive(file_name)[1]
3623+
elif file_name.startswith("..\\"):
36223624
file_name = re.sub(r"^(\.\.\\)+", "", file_name)
3623-
elif (file_name.startswith("$(")):
3625+
elif file_name.startswith("$("):
36243626
file_name = re.sub(r"^\$\([^)]+\)\\", "", file_name)
36253627
detail.append(["ObjectFileName", "$(IntDir)\\" + file_name])
36263628
grouped_sources[group].append([element, {"Include": source}] + detail)

0 commit comments

Comments
 (0)