Skip to content

Commit 7cdefbb

Browse files
cclausskkoopa
authored andcommitted
Fix compatibility with Python >= 3.12 (#987)
1 parent 6193f82 commit 7cdefbb

File tree

2 files changed

+55
-1
lines changed

2 files changed

+55
-1
lines changed

.github/workflows/ci.yml

+54
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
# https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-nodejs
2+
# https://github.com/actions/setup-node
3+
# https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
4+
5+
name: ci
6+
on:
7+
push:
8+
# branches: [main]
9+
pull_request:
10+
# branches: [main]
11+
workflow_dispatch:
12+
permissions:
13+
contents: read
14+
jobs:
15+
ci:
16+
strategy:
17+
fail-fast: false
18+
matrix: # TODO: Enable 23.x after nodejs/nan#979 or similar.
19+
node-version: [22.x, 21.x, 20.x, 19.x, 18.x, 17.x, 16.x]
20+
os: [windows-latest]
21+
include:
22+
- node-version: lts/*
23+
os: macos-13 # macOS on Intel
24+
- node-version: lts/*
25+
os: macos-latest # macOS on arm64
26+
- node-version: lts/*
27+
os: ubuntu-latest # Linux on x64
28+
- node-version: lts/*
29+
os: ubuntu-24.04-arm # Linux on arm64
30+
- node-version: lts/*
31+
os: windows-2025
32+
- node-version: 14.x
33+
os: windows-2019
34+
- node-version: 13.x
35+
os: windows-2019
36+
- node-version: 12.x
37+
os: windows-2019
38+
- node-version: 10.x
39+
os: windows-2019
40+
- node-version: 8.x
41+
os: windows-2019
42+
runs-on: ${{ matrix.os }}
43+
steps:
44+
- uses: actions/checkout@v4
45+
- uses: actions/setup-node@v4
46+
with:
47+
node-version: ${{ matrix.node-version }}
48+
- run: npm install
49+
# TODO: On Windows Node.js v11 these will fail but `make test` will succeed
50+
- if: matrix.node-version != '11.x'
51+
run: |
52+
npm run-script rebuild-tests
53+
npm test
54+
- run: make test

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"commander": "^2.8.1",
3030
"glob": "^5.0.14",
3131
"request": "=2.81.0",
32-
"node-gyp": "~8.4.1",
32+
"node-gyp": "~v10.3.1",
3333
"readable-stream": "^2.1.4",
3434
"tap": "~0.7.1",
3535
"xtend": "~4.0.0"

0 commit comments

Comments
 (0)