Skip to content

Commit 00f55f5

Browse files
targosRafaelGSS
authored andcommitted
deps: silence irrelevant V8 warning
PR-URL: #45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #52465 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent 764085a commit 00f55f5

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
# Reset this number to 0 on major V8 upgrades.
3939
# Increment by one for each non-official patch applied to deps/v8.
40-
'v8_embedder_string': '-node.1',
40+
'v8_embedder_string': '-node.2',
4141

4242
##### V8 defaults for Node.js #####
4343

deps/v8/include/v8-persistent-handle.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ class NonCopyablePersistentTraits {
241241
* This will clone the contents of storage cell, but not any of the flags, etc.
242242
*/
243243
template <class T>
244-
struct V8_DEPRECATED("Use v8::Global instead") CopyablePersistentTraits {
244+
struct CopyablePersistentTraits {
245245
using CopyablePersistent = Persistent<T, CopyablePersistentTraits<T>>;
246246
static const bool kResetInDestructor = true;
247247
template <class S, class M>

0 commit comments

Comments
 (0)