Skip to content

Commit 01cea9a

Browse files
committed
deps: V8: cherry-pick a2cae2180a7a
Original commit message: [runtime] Fix handling of interceptors, pt.2 Stores to undeclared global in strict mode should throw ReferenceError. Bug: chromium:1309225 Change-Id: Iac7c55da2ff9c16e488b4fc66408c5300469873e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3553099 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#79625} Refs: v8/v8@a2cae21 PR-URL: #42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent d9d26b0 commit 01cea9a

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.8',
39+
'v8_embedder_string': '-node.9',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/objects/objects.cc

+4
Original file line numberDiff line numberDiff line change
@@ -2702,6 +2702,10 @@ Maybe<bool> Object::SetSuperProperty(LookupIterator* it, Handle<Object> value,
27022702
JSReceiver::GetOwnPropertyDescriptor(&own_lookup, &desc);
27032703
MAYBE_RETURN(owned, Nothing<bool>());
27042704
if (!owned.FromJust()) {
2705+
if (!CheckContextualStoreToJSGlobalObject(&own_lookup,
2706+
should_throw)) {
2707+
return Nothing<bool>();
2708+
}
27052709
return JSReceiver::CreateDataProperty(&own_lookup, value,
27062710
should_throw);
27072711
}

0 commit comments

Comments
 (0)