Skip to content

Commit 01d7c46

Browse files
danbevtargos
authored andcommitted
Revert "src: ignore GCC -Wcast-function-type for v8.h"
This reverts commit f21cf45 as this has now been included in the V8 version being used. PR-URL: #35758 Refs: v8/v8@f08cbfd Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 6211ffd commit 01d7c46

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

src/string_bytes.h

-7
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,7 @@
2626

2727
// Decodes a v8::Local<v8::String> or Buffer to a raw char*
2828

29-
#if (__GNUC__ >= 8) && !defined(__clang__)
30-
#pragma GCC diagnostic push
31-
#pragma GCC diagnostic ignored "-Wcast-function-type"
32-
#endif
3329
#include "v8.h"
34-
#if (__GNUC__ >= 8) && !defined(__clang__)
35-
#pragma GCC diagnostic pop
36-
#endif
3730
#include "env-inl.h"
3831

3932
#include <string>

test/cctest/test_aliased_buffer.cc

-7
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,4 @@
1-
#if (__GNUC__ >= 8) && !defined(__clang__)
2-
#pragma GCC diagnostic push
3-
#pragma GCC diagnostic ignored "-Wcast-function-type"
4-
#endif
51
#include "v8.h"
6-
#if (__GNUC__ >= 8) && !defined(__clang__)
7-
#pragma GCC diagnostic pop
8-
#endif
92
#include "aliased_buffer.h"
103
#include "node_test_fixture.h"
114

0 commit comments

Comments
 (0)