Skip to content

Commit 02ac8ba

Browse files
refackgibfahn
authored andcommitted
test: change tmp directories prefix
`.tmp` prefix allows easier exclusion PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent e80d878 commit 02ac8ba

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.eslintignore

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ lib/internal/v8_prof_polyfill.js
22
lib/punycode.js
33
test/addons/??_*
44
test/fixtures
5-
test/tmp*
65
tools/eslint
76
tools/icu
87
node_modules

test/common/index.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@ const noop = () => {};
3838

3939
exports.fixturesDir = fixturesDir;
4040

41-
exports.tmpDirName = 'tmp';
41+
// Using a `.` prefixed name, which is the convention for "hidden" on POSIX,
42+
// gets tools to ignore it by default or by simple rules, especially eslint.
43+
exports.tmpDirName = '.tmp';
4244
// PORT should match the definition in test/testpy/__init__.py.
4345
exports.PORT = +process.env.NODE_COMMON_PORT || 12346;
4446
exports.isWindows = process.platform === 'win32';

0 commit comments

Comments
 (0)