Skip to content

Commit 03bd649

Browse files
joyeecheungtargos
authored andcommitted
test: show stderr on v8 coverage test failures
PR-URL: #26513 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com>
1 parent ab70c96 commit 03bd649

File tree

1 file changed

+24
-0
lines changed

1 file changed

+24
-0
lines changed

test/parallel/test-v8-coverage.js

+24
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ function nextdir() {
2222
const output = spawnSync(process.execPath, [
2323
require.resolve('../fixtures/v8-coverage/basic')
2424
], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } });
25+
if (output.status !== 0) {
26+
console.log(output.stderr.toString());
27+
}
2528
assert.strictEqual(output.status, 0);
2629
assert.strictEqual(output.stderr.toString(), '');
2730
const fixtureCoverage = getFixtureCoverage('basic.js', coverageDirectory);
@@ -38,6 +41,9 @@ function nextdir() {
3841
const output = spawnSync(process.execPath, [
3942
require.resolve('../fixtures/v8-coverage/exit-1')
4043
], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } });
44+
if (output.status !== 1) {
45+
console.log(output.stderr.toString());
46+
}
4147
assert.strictEqual(output.status, 1);
4248
assert.strictEqual(output.stderr.toString(), '');
4349
const fixtureCoverage = getFixtureCoverage('exit-1.js', coverageDirectory);
@@ -55,6 +61,9 @@ function nextdir() {
5561
require.resolve('../fixtures/v8-coverage/sigint')
5662
], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } });
5763
if (!common.isWindows) {
64+
if (output.signal !== 'SIGINT') {
65+
console.log(output.stderr.toString());
66+
}
5867
assert.strictEqual(output.signal, 'SIGINT');
5968
}
6069
assert.strictEqual(output.stderr.toString(), '');
@@ -72,6 +81,9 @@ function nextdir() {
7281
const output = spawnSync(process.execPath, [
7382
require.resolve('../fixtures/v8-coverage/spawn-subprocess')
7483
], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } });
84+
if (output.status !== 0) {
85+
console.log(output.stderr.toString());
86+
}
7587
assert.strictEqual(output.status, 0);
7688
assert.strictEqual(output.stderr.toString(), '');
7789
const fixtureCoverage = getFixtureCoverage('subprocess.js',
@@ -89,6 +101,9 @@ function nextdir() {
89101
const output = spawnSync(process.execPath, [
90102
require.resolve('../fixtures/v8-coverage/worker')
91103
], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } });
104+
if (output.status !== 0) {
105+
console.log(output.stderr.toString());
106+
}
92107
assert.strictEqual(output.status, 0);
93108
assert.strictEqual(output.stderr.toString(), '');
94109
const fixtureCoverage = getFixtureCoverage('subprocess.js',
@@ -106,6 +121,9 @@ function nextdir() {
106121
const output = spawnSync(process.execPath, [
107122
require.resolve('../fixtures/v8-coverage/spawn-subprocess-no-cov')
108123
], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } });
124+
if (output.status !== 0) {
125+
console.log(output.stderr.toString());
126+
}
109127
assert.strictEqual(output.status, 0);
110128
assert.strictEqual(output.stderr.toString(), '');
111129
const fixtureCoverage = getFixtureCoverage('subprocess.js',
@@ -119,6 +137,9 @@ function nextdir() {
119137
const output = spawnSync(process.execPath, [
120138
require.resolve('../fixtures/v8-coverage/async-hooks')
121139
], { env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory } });
140+
if (output.status !== 0) {
141+
console.log(output.stderr.toString());
142+
}
122143
assert.strictEqual(output.status, 0);
123144
assert.strictEqual(output.stderr.toString(), '');
124145
const fixtureCoverage = getFixtureCoverage('async-hooks.js',
@@ -138,6 +159,9 @@ function nextdir() {
138159
cwd: tmpdir.path,
139160
env: { ...process.env, NODE_V8_COVERAGE: coverageDirectory }
140161
});
162+
if (output.status !== 0) {
163+
console.log(output.stderr.toString());
164+
}
141165
assert.strictEqual(output.status, 0);
142166
assert.strictEqual(output.stderr.toString(), '');
143167
const fixtureCoverage = getFixtureCoverage('basic.js',

0 commit comments

Comments
 (0)