Skip to content

Commit 041885e

Browse files
joyeecheungRafaelGSS
authored andcommitted
test: use --port=0 in debugger tests that do not have to work on 9229
To avoid failures when there is another running process occupying the port 9229 which may happen if there is a stale process, use the --port argument of node-inspect to use a random port in tests that don't have to work on port 9229. The following tests are not touched: - test-debugger-custom-port: tests a specific port - test-debugger-debug-brk: tests a specific port - test-debugger-invalid-args: tests other inspect combinations - test-debugger-pid: node-inspect does not support -p and --port together - test-debugger-launch: tests that default port is 9229 PR-URL: #47274 Refs: #47146 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 0bbce03 commit 041885e

26 files changed

+26
-25
lines changed

test/sequential/test-debugger-auto-resume.mjs

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ addLibraryPath(process.env);
2121
};
2222
env.NODE_INSPECT_RESUME_ON_START = '1';
2323

24-
const cli = startCLI([script], [], {
24+
const cli = startCLI(['--port=0', script], [], {
2525
env,
2626
});
2727

test/sequential/test-debugger-backtrace.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const path = require('path');
1313
{
1414
const scriptFullPath = fixtures.path('debugger', 'backtrace.js');
1515
const script = path.relative(process.cwd(), scriptFullPath);
16-
const cli = startCLI([script]);
16+
const cli = startCLI(['--port=0', script]);
1717

1818
async function runTest() {
1919
try {

test/sequential/test-debugger-break.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const path = require('path');
1111

1212
const scriptFullPath = fixtures.path('debugger', 'break.js');
1313
const script = path.relative(process.cwd(), scriptFullPath);
14-
const cli = startCLI([script]);
14+
const cli = startCLI(['--port=0', script]);
1515

1616
(async () => {
1717
await cli.waitForInitialBreak();

test/sequential/test-debugger-breakpoint-exists.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const startCLI = require('../common/debugger');
99

1010
// Test for "Breakpoint at specified location already exists" error.
1111
const script = fixtures.path('debugger', 'three-lines.js');
12-
const cli = startCLI([script]);
12+
const cli = startCLI(['--port=0', script]);
1313

1414
(async () => {
1515
try {

test/sequential/test-debugger-clear-breakpoints.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const path = require('path');
1313
{
1414
const scriptFullPath = fixtures.path('debugger', 'break.js');
1515
const script = path.relative(process.cwd(), scriptFullPath);
16-
const cli = startCLI([script]);
16+
const cli = startCLI(['--port=0', script]);
1717

1818
function onFatal(error) {
1919
cli.quit();

test/sequential/test-debugger-exceptions.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const path = require('path');
1313
{
1414
const scriptFullPath = fixtures.path('debugger', 'exceptions.js');
1515
const script = path.relative(process.cwd(), scriptFullPath);
16-
const cli = startCLI([script]);
16+
const cli = startCLI(['--port=0', script]);
1717

1818
(async () => {
1919
try {

test/sequential/test-debugger-exec-scope.mjs

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import startCLI from '../common/debugger.js';
77

88
import assert from 'assert';
99

10-
const cli = startCLI([path('debugger/backtrace.js')]);
10+
const cli = startCLI(['--port=0', path('debugger/backtrace.js')]);
1111

1212
try {
1313
await cli.waitForInitialBreak();

test/sequential/test-debugger-exec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const startCLI = require('../common/debugger');
88

99
const assert = require('assert');
1010

11-
const cli = startCLI([fixtures.path('debugger/alive.js')]);
11+
const cli = startCLI(['--port=0', fixtures.path('debugger/alive.js')]);
1212

1313
async function waitInitialBreak() {
1414
try {

test/sequential/test-debugger-heap-profiler.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const filename = path.join(tmpdir.path, 'node.heapsnapshot');
1717
// Heap profiler take snapshot.
1818
{
1919
const opts = { cwd: tmpdir.path };
20-
const cli = startCLI([fixtures.path('debugger/empty.js')], [], opts);
20+
const cli = startCLI(['--port=0', fixtures.path('debugger/empty.js')], [], opts);
2121

2222
async function waitInitialBreak() {
2323
try {

test/sequential/test-debugger-help.mjs

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import startCLI from '../common/debugger.js';
77

88
import assert from 'assert';
99

10-
const cli = startCLI([path('debugger', 'empty.js')]);
10+
const cli = startCLI(['--port=0', path('debugger', 'empty.js')]);
1111

1212
try {
1313
await cli.waitForInitialBreak();

test/sequential/test-debugger-launch.mjs

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { skipIfInspectorDisabled } from '../common/index.mjs';
22
skipIfInspectorDisabled();
33

4+
// This must be in sequential because we check that the default port is 9229.
45
import { path } from '../common/fixtures.mjs';
56
import startCLI from '../common/debugger.js';
67

test/sequential/test-debugger-list.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const startCLI = require('../common/debugger');
88

99
const assert = require('assert');
1010

11-
const cli = startCLI([fixtures.path('debugger/three-lines.js')]);
11+
const cli = startCLI(['--port=0', fixtures.path('debugger/three-lines.js')]);
1212

1313
(async () => {
1414
await cli.waitForInitialBreak();

test/sequential/test-debugger-low-level.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const assert = require('assert');
99

1010
// Debugger agent direct access.
1111
{
12-
const cli = startCLI([fixtures.path('debugger/three-lines.js')]);
12+
const cli = startCLI(['--port=0', fixtures.path('debugger/three-lines.js')]);
1313
const scriptPattern = /^\* (\d+): \S+debugger(?:\/|\\)three-lines\.js/m;
1414

1515
async function testDebuggerLowLevel() {

test/sequential/test-debugger-object-type-remote-object.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const startCLI = require('../common/debugger');
88

99
const assert = require('assert');
1010

11-
const cli = startCLI([fixtures.path('debugger/empty.js')]);
11+
const cli = startCLI(['--port=0', fixtures.path('debugger/empty.js')]);
1212

1313
(async () => {
1414
await cli.waitForInitialBreak();

test/sequential/test-debugger-preserve-breaks.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const script = path.relative(process.cwd(), scriptFullPath);
1414

1515
// Run after quit.
1616
const runTest = async () => {
17-
const cli = startCLI([script]);
17+
const cli = startCLI(['--port=0', script]);
1818
try {
1919
await cli.waitForInitialBreak();
2020
await cli.waitForPrompt();

test/sequential/test-debugger-profile-command.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const assert = require('assert');
1010
const fs = require('fs');
1111
const path = require('path');
1212

13-
const cli = startCLI([fixtures.path('debugger/empty.js')]);
13+
const cli = startCLI(['--port=0', fixtures.path('debugger/empty.js')]);
1414

1515
const rootDir = path.resolve(__dirname, '..', '..');
1616

test/sequential/test-debugger-profile.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function delay(ms) {
1414

1515
// Profiles.
1616
{
17-
const cli = startCLI([fixtures.path('debugger/empty.js')]);
17+
const cli = startCLI(['--port=0', fixtures.path('debugger/empty.js')]);
1818

1919
function onFatal(error) {
2020
cli.quit();

test/sequential/test-debugger-repeat-last.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const fixture = path('debugger-repeat-last.js');
88

99
const args = [
1010
'inspect',
11-
`--port=${common.PORT}`,
11+
'--port=0',
1212
fixture,
1313
];
1414

test/sequential/test-debugger-restart-message.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const startCLI = require('../common/debugger');
1414
// Using `restart` should result in only one "Connect/For help" message.
1515
{
1616
const script = fixtures.path('debugger', 'three-lines.js');
17-
const cli = startCLI([script]);
17+
const cli = startCLI(['--port=0', script]);
1818

1919
const listeningRegExp = /Debugger listening on/g;
2020

test/sequential/test-debugger-run-after-quit-restart.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const path = require('path');
1313
{
1414
const scriptFullPath = fixtures.path('debugger', 'three-lines.js');
1515
const script = path.relative(process.cwd(), scriptFullPath);
16-
const cli = startCLI([script]);
16+
const cli = startCLI(['--port=0', script]);
1717

1818
function onFatal(error) {
1919
cli.quit();

test/sequential/test-debugger-sb-before-load.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const script = path.relative(process.cwd(), scriptFullPath);
1717
const otherScriptFullPath = fixtures.path('debugger', 'cjs', 'other.js');
1818
const otherScript = path.relative(process.cwd(), otherScriptFullPath);
1919

20-
const cli = startCLI([script]);
20+
const cli = startCLI(['--port=0', script]);
2121

2222
(async () => {
2323
await cli.waitForInitialBreak();

test/sequential/test-debugger-scripts.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const assert = require('assert');
1111
// List scripts.
1212
{
1313
const script = fixtures.path('debugger', 'three-lines.js');
14-
const cli = startCLI([script]);
14+
const cli = startCLI(['--port=0', script]);
1515

1616
(async () => {
1717
try {

test/sequential/test-debugger-set-context-line-number.mjs

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import startCLI from '../common/debugger.js';
77
import assert from 'assert';
88

99
const script = path('debugger', 'twenty-lines.js');
10-
const cli = startCLI([script]);
10+
const cli = startCLI(['--port=0', script]);
1111

1212
function onFatal(error) {
1313
cli.quit();

test/sequential/test-debugger-use-strict.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const assert = require('assert');
1111
// Test for files that start with strict directive.
1212
{
1313
const script = fixtures.path('debugger', 'use-strict.js');
14-
const cli = startCLI([script]);
14+
const cli = startCLI(['--port=0', script]);
1515

1616
function onFatal(error) {
1717
cli.quit();

test/sequential/test-debugger-watch-validation.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const startCLI = require('../common/debugger');
88

99
const assert = require('assert');
1010

11-
const cli = startCLI([fixtures.path('debugger/break.js')]);
11+
const cli = startCLI(['--port=0', fixtures.path('debugger/break.js')]);
1212

1313
(async () => {
1414
await cli.waitForInitialBreak();

test/sequential/test-debugger-watchers.mjs

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import startCLI from '../common/debugger.js';
77
import assert from 'assert';
88

99
const script = path('debugger', 'break.js');
10-
const cli = startCLI([script]);
10+
const cli = startCLI(['--port=0', script]);
1111

1212
function onFatal(error) {
1313
cli.quit();

0 commit comments

Comments
 (0)