Skip to content

Commit 04798fb

Browse files
zcbenzmarco-ippolito
authored andcommitted
build: fix build warning of c-ares under GN build
PR-URL: #53750 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent 0ad4b7c commit 04798fb

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

deps/cares/unofficial.gni

+11-5
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,17 @@ template("cares_gn_build") {
6565
sources += gypi_values.cares_sources_mac
6666
}
6767

68-
if (is_clang || !is_win) {
69-
cflags_c = [
70-
"-Wno-implicit-fallthrough",
71-
"-Wno-unreachable-code",
72-
]
68+
if (is_clang) {
69+
if (is_win) {
70+
cflags_c = [
71+
"-Wno-macro-redefined",
72+
]
73+
} else {
74+
cflags_c = [
75+
"-Wno-implicit-fallthrough",
76+
"-Wno-unreachable-code",
77+
]
78+
}
7379
}
7480
}
7581
}

0 commit comments

Comments
 (0)