repl: deprecate repl.builtinModules

Author: dario-piotrowicz

doc/api/deprecations.md

@@ -3849,6 +3849,22 @@ Type: Documentation-only
 `process.features.tls_alpn`, `process.features.tls_ocsp`, and `process.features.tls_sni` are
 deprecated, as their values are guaranteed to be identical to that of `process.features.tls`.
 
+### DEP0190: `repl.builtinModules`
+
+<!-- YAML
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/57508
+    description: Documentation-only (supports [`--pending-deprecation`][]).
+-->
+
+Type: Documentation-only
+
+The `node:repl` module exports a `builtinModules` property that contains an array
+of built-in modules. This was incomplete and matched the already deprecated
+`repl._builtinLibs` (DEP0142) instead it's better to rely
+upon `require('node:module').builtinModules`.
+
 [NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
 [RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3
 [RFC 8247 Section 2.4]: https://www.rfc-editor.org/rfc/rfc8247#section-2.4

doc/api/repl.md

@@ -646,8 +646,11 @@ with REPL instances programmatically.
 
 <!-- YAML
 added: v14.5.0
+deprecated: REPLACEME
 -->
 
+> Stability: 0 - Deprecated. Use `module.builtinModules` instead.
+
 * {string\[]}
 
 A list of the names of all Node.js modules, e.g., `'http'`.

lib/repl.js

@@ -1862,9 +1862,17 @@ module.exports = {
 
 ObjectDefineProperty(module.exports, 'builtinModules', {
   __proto__: null,
-  get: () => _builtinLibs,
-  set: (val) => _builtinLibs = val,
-  enumerable: true,
+  get: pendingDeprecation ? deprecate(
+    () => require(''),
+    'repl.builtinModules is deprecated. Check module.builtinModules instead',
+    'DEP0190',
+  ) : () => _builtinLibs,
+  set: pendingDeprecation ? deprecate(
+    (val) => _builtinLibs = val,
+    'repl.builtinModules is deprecated. Check module.builtinModules instead',
+    'DEP0190',
+  ) : (val) => _builtinLibs = val,
+  enumerable: false,
   configurable: true,
 });
 

test/parallel/test-repl-options.js

@@ -29,14 +29,17 @@ const repl = require('repl');
 const cp = require('child_process');
 
 assert.strictEqual(repl.repl, undefined);
+
 repl._builtinLibs; // eslint-disable-line no-unused-expressions
+repl.builtinModules; // eslint-disable-line no-unused-expressions
 
 common.expectWarning({
   DeprecationWarning: {
     DEP0142:
       'repl._builtinLibs is deprecated. Check module.builtinModules instead',
+    DEP0190: 'repl.builtinModules is deprecated. Check module.builtinModules instead',
     DEP0141: 'repl.inputStream and repl.outputStream are deprecated. ' +
-             'Use repl.input and repl.output instead',
+      'Use repl.input and repl.output instead',
   }
 });
 
@@ -62,9 +65,9 @@ assert.strictEqual(r1.replMode, repl.REPL_MODE_SLOPPY);
 assert.strictEqual(r1.historySize, 30);
 
 // 2
-function writer() {}
+function writer() { }
 
-function evaler() {}
+function evaler() { }
 const r2 = repl.start({
   input: stream,
   output: stream,