Skip to content

Commit 07a4e94

Browse files
tniessenUlisesGascon
authored andcommitted
src: assert return value of BN_bn2binpad
Every other invocation of BN_bn2binpad checks the return value. For safety and consistency, do so in RandomPrimeTraits::EncodeOutput() as well. PR-URL: #50860 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent f4070dd commit 07a4e94

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/crypto/crypto_random.cc

+4-4
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ Maybe<bool> RandomPrimeTraits::EncodeOutput(
7575
size_t size = BN_num_bytes(params.prime.get());
7676
std::shared_ptr<BackingStore> store =
7777
ArrayBuffer::NewBackingStore(env->isolate(), size);
78-
BN_bn2binpad(
79-
params.prime.get(),
80-
reinterpret_cast<unsigned char*>(store->Data()),
81-
size);
78+
CHECK_EQ(static_cast<int>(size),
79+
BN_bn2binpad(params.prime.get(),
80+
reinterpret_cast<unsigned char*>(store->Data()),
81+
size));
8282
*result = ArrayBuffer::New(env->isolate(), store);
8383
return Just(true);
8484
}

0 commit comments

Comments
 (0)