Skip to content

Commit 090ad7d

Browse files
committed
build: remove test-tarball action for windows + osx
This GitHub action takes quite a bit of time to build and is regularly flaky. Removing the OSX and Windows target from this action to avoid having red actions CI runs. Refs: #34123 PR-URL: #34440 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent ec2ffd6 commit 090ad7d

File tree

1 file changed

+1
-76
lines changed

1 file changed

+1
-76
lines changed

.github/workflows/build-tarball.yml

+1-76
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
build-tarball:
1414
env:
1515
PYTHON_VERSION: 3.8
16-
runs-on: macos-latest
16+
runs-on: ubuntu-latest
1717
steps:
1818
- uses: actions/checkout@v2
1919
- name: Set up Python ${{ env.PYTHON_VERSION }}
@@ -68,78 +68,3 @@ jobs:
6868
run: |
6969
cd $TAR_DIR
7070
make run-ci -j2 V=1 TEST_CI_ARGS="-p dots"
71-
test-tarball-windows:
72-
needs: build-tarball
73-
runs-on: windows-latest
74-
steps:
75-
- name: Set up autocrlf
76-
run: |
77-
git config --global core.autocrlf true
78-
- uses: actions/checkout@v2
79-
- name: Set up Python 3.8
80-
uses: actions/setup-python@v2
81-
with:
82-
python-version: 3.8
83-
- name: Environment Information
84-
run: npx envinfo
85-
- name: Download tarball
86-
uses: actions/download-artifact@v1
87-
with:
88-
name: tarballs
89-
- name: Extract tarball
90-
run: |
91-
7z x tarballs/*.tar.gz
92-
7z x *.tar -ttar
93-
- name: Install deps
94-
run: choco install nasm
95-
- name: Build
96-
run: |
97-
$env:DEBUG_HELPER=1
98-
$tarfile = dir *.tar
99-
cd $tarfile.BaseName
100-
$env:msbuild_args="/binaryLogger:node.binlog"
101-
./vcbuild.bat x64 release msi
102-
echo "::set-env name=TAR_DIR::$pwd"
103-
- name: Copy out directory to checkout dir
104-
run: Move-Item -Path "$env:TAR_DIR\out" -Destination "$env:GITHUB_WORKSPACE"
105-
- name: "Test JS Suites"
106-
shell: cmd
107-
run: |
108-
set DEBUG_HELPER=1
109-
./vcbuild.bat release noprojgen nobuild ignore-flaky test-ci-js
110-
- name: "Test C++ Suites"
111-
shell: cmd
112-
run: |
113-
set DEBUG_HELPER=1
114-
./vcbuild.bat release noprojgen nobuild ignore-flaky test-ci-native
115-
test-tarball-macOS:
116-
needs: build-tarball
117-
runs-on: macos-latest
118-
steps:
119-
- uses: actions/checkout@v2
120-
- name: Set up Python ${{ env.PYTHON_VERSION }}
121-
uses: actions/setup-python@v1
122-
with:
123-
PYTHON_VERSION: ${{ env.PYTHON_VERSION }}
124-
- name: Environment Information
125-
run: npx envinfo
126-
- name: Download tarball
127-
uses: actions/download-artifact@v1
128-
with:
129-
name: tarballs
130-
- name: Extract tarball
131-
run: |
132-
tar xzf tarballs/*.tar.gz
133-
echo "::set-env name=TAR_DIR::`basename tarballs/*.tar.gz .tar.gz`"
134-
- name: Copy directories needed for testing
135-
run: |
136-
cp -r tools/node_modules $TAR_DIR/tools
137-
cp -r tools/eslint-rules $TAR_DIR/tools
138-
- name: Build
139-
run: |
140-
cd $TAR_DIR
141-
make build-ci -j8 V=1
142-
- name: Test
143-
run: |
144-
cd $TAR_DIR
145-
make run-ci -j8 V=1 TEST_CI_ARGS="-p dots"

0 commit comments

Comments
 (0)