Skip to content

Commit 0a1f7fe

Browse files
digitalinfinitygibfahn
authored andcommitted
build: skip bin override on windows
PR-URL: #16460 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent ee40368 commit 0a1f7fe

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

configure

+5-2
Original file line numberDiff line numberDiff line change
@@ -1351,7 +1351,9 @@ def configure_inspector(o):
13511351
o['variables']['v8_enable_inspector'] = 0 if disable_inspector else 1
13521352

13531353

1354-
def get_bin_override():
1354+
def make_bin_override():
1355+
if sys.platform == 'win32':
1356+
raise Exception('make_bin_override should not be called on win32.')
13551357
# If the system python is not the python we are running (which should be
13561358
# python 2), then create a directory with a symlink called `python` to our
13571359
# sys.executable. This directory will be prefixed to the PATH, so that
@@ -1460,7 +1462,8 @@ if options.prefix:
14601462

14611463
config = '\n'.join(map('='.join, config.iteritems())) + '\n'
14621464

1463-
bin_override = get_bin_override()
1465+
# On Windows there's no reason to search for a different python binary.
1466+
bin_override = None if sys.platform == 'win32' else make_bin_override()
14641467
if bin_override:
14651468
config = 'export PATH:=' + bin_override + ':$(PATH)\n' + config
14661469

0 commit comments

Comments
 (0)