src: refactor coverage connection

- Refactor the C++ class to be resuable for other types of profiles
- Move the try-catch block around coverage collection callback
  to be inside the callback to silence potential JSON or write
  errors.
- Use Function::Call instead of MakeCallback to call the coverage
  message callback since it does not actually need async hook
  handling. This way we no longer needs to disable the async
  hooks when writing the coverage results.
- Renames `lib/internal/coverage-gen/with_profiler.js` to
  `lib/internal/profiler.js` because it is now the only way
  to generate coverage.

PR-URL: #26513
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Coe <bencoe@gmail.com>

Author: joyeecheung

lib/internal/bootstrap/pre_execution.js

@@ -67,7 +67,7 @@ function setupCoverageHooks(dir) {
   const {
     writeCoverage,
     setCoverageDirectory
-  } = require('internal/coverage-gen/with_profiler');
+  } = require('internal/profiler');
   setCoverageDirectory(coverageDirectory);
   process.on('exit', writeCoverage);
   process.reallyExit = (code) => {

lib/internal/process/per_thread.js

@@ -158,7 +158,7 @@ function wrapProcessMethods(binding) {
   function kill(pid, sig) {
     var err;
     if (process.env.NODE_V8_COVERAGE) {
-      const { writeCoverage } = require('internal/coverage-gen/with_profiler');
+      const { writeCoverage } = require('internal/profiler');
       writeCoverage();
     }
 

lib/internal/coverage-gen/with_profiler.js lib/internal/profiler.js

@@ -21,23 +21,16 @@ function writeCoverage() {
   }
 
   const target = join(coverageDirectory, filename);
-  try {
-    disableAllAsyncHooks();
-    internalBinding('coverage').end((msg) => {
+  internalBinding('profiler').endCoverage((msg) => {
+    try {
       const coverageInfo = JSON.parse(msg).result;
       if (coverageInfo) {
         writeFileSync(target, JSON.stringify(coverageInfo));
       }
-    });
-  } catch (err) {
-    console.error(err);
-  }
-}
-
-function disableAllAsyncHooks() {
-  const { getHookArrays } = require('internal/async_hooks');
-  const [hooks_array] = getHookArrays();
-  hooks_array.forEach((hook) => { hook.disable(); });
+    } catch (err) {
+      console.error(err);
+    }
+  });
 }
 
 function setCoverageDirectory(dir) {

node.gyp

@@ -99,7 +99,6 @@
       'lib/internal/cluster/worker.js',
       'lib/internal/console/constructor.js',
       'lib/internal/console/global.js',
-      'lib/internal/coverage-gen/with_profiler.js',
       'lib/internal/crypto/certificate.js',
       'lib/internal/crypto/cipher.js',
       'lib/internal/crypto/diffiehellman.js',
@@ -168,6 +167,7 @@
       'lib/internal/process/worker_thread_only.js',
       'lib/internal/process/report.js',
       'lib/internal/process/task_queues.js',
+      'lib/internal/profiler.js',
       'lib/internal/querystring.js',
       'lib/internal/readline.js',
       'lib/internal/repl.js',

src/env.h

@@ -468,7 +468,7 @@ struct CompileFnEntry {
 #define DEBUG_CATEGORY_NAMES(V)                                                \
   NODE_ASYNC_PROVIDER_TYPES(V)                                                 \
   V(INSPECTOR_SERVER)                                                          \
-  V(COVERAGE)
+  V(INSPECTOR_PROFILER)
 
 enum class DebugCategory {
 #define V(name) name,

src/inspector/node_inspector.gypi

@@ -45,7 +45,7 @@
     '../../src/inspector_io.cc',
     '../../src/inspector_agent.h',
     '../../src/inspector_io.h',
-    '../../src/inspector_coverage.cc',
+    '../../src/inspector_profiler.cc',
     '../../src/inspector_js_api.cc',
     '../../src/inspector_socket.cc',
     '../../src/inspector_socket.h',