Skip to content

Commit 0b302e4

Browse files
rneatherwayaddaleax
authored andcommitted
lib: fix a few minor issues flagged by lgtm
* Confusing (but correct) regex using `A-z` character range by accident * Add the status argument to afterShutdown PR-URL: #25873 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
1 parent 353de0f commit 0b302e4

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

lib/internal/http2/core.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1518,7 +1518,8 @@ function streamOnPause() {
15181518
this[kHandle].readStop();
15191519
}
15201520

1521-
function afterShutdown() {
1521+
function afterShutdown(status) {
1522+
// Currently this status value is unused
15221523
this.callback();
15231524
const stream = this.handle[kOwner];
15241525
if (stream)

tools/cpplint.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,7 @@ def GetNonHeaderExtensions():
636636

637637
_RIGHT_LEANING_POINTER_PATTERN = re.compile(r'[^=|(,\s><);&?:}]'
638638
r'(?<!(sizeof|return))'
639-
r'\s\*[a-zA-z_][0-9a-zA-z_]*')
639+
r'\s\*[a-zA-Z_][0-9a-zA-Z_]*')
640640

641641
_regexp_compile_cache = {}
642642

0 commit comments

Comments
 (0)