Skip to content

Commit 0c32918

Browse files
HBSPStargos
authored andcommitted
stream: change stream to use index instead of for...of
PR-URL: #54474 Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent d53e6cf commit 0c32918

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

lib/stream.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@ Stream.isReadable = utils.isReadable;
6161
Stream.isWritable = utils.isWritable;
6262

6363
Stream.Readable = require('internal/streams/readable');
64-
for (const key of ObjectKeys(streamReturningOperators)) {
64+
const streamKeys = ObjectKeys(streamReturningOperators);
65+
for (let i = 0; i < streamKeys.length; i++) {
66+
const key = streamKeys[i];
6567
const op = streamReturningOperators[key];
6668
function fn(...args) {
6769
if (new.target) {
@@ -79,7 +81,9 @@ for (const key of ObjectKeys(streamReturningOperators)) {
7981
writable: true,
8082
});
8183
}
82-
for (const key of ObjectKeys(promiseReturningOperators)) {
84+
const promiseKeys = ObjectKeys(promiseReturningOperators);
85+
for (let i = 0; i < promiseKeys.length; i++) {
86+
const key = promiseKeys[i];
8387
const op = promiseReturningOperators[key];
8488
function fn(...args) {
8589
if (new.target) {

0 commit comments

Comments
 (0)