src: fix Coverity issue regarding unnecessary copy

anonrig · ruyadorno · commit 0c38184d6210 · 2023-09-12T10:58:58.000-04:00
PR-URL: #48565 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
diff --git a/src/node_v8_platform-inl.h b/src/node_v8_platform-inl.h
@@ -130,7 +130,7 @@ struct V8Platform {
     constexpr auto convert_to_set =
         [](std::vector<std::string_view> categories) -> std::set<std::string> {
       std::set<std::string> out;
-      for (const auto s : categories) {
+      for (const auto& s : categories) {
         out.emplace(s);
       }
       return out;

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ struct V8Platform {`
`130`	`130`	`constexpr auto convert_to_set =`
`131`	`131`	`[](std::vector<std::string_view> categories) -> std::set<std::string> {`
`132`	`132`	`std::set<std::string> out;`
`133`		`- for (const auto s : categories) {`
	`133`	`+ for (const auto& s : categories) {`
`134`	`134`	`out.emplace(s);`
`135`	`135`	`}`
`136`	`136`	`return out;`