Skip to content

Commit 0fd3d91

Browse files
nektroaduh95
authored andcommitted
test: more common.mustNotCall in net, tls
PR-URL: #57246 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
1 parent 03844d9 commit 0fd3d91

5 files changed

+6
-12
lines changed

test/parallel/test-net-eaddrinuse.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,8 @@ const common = require('../common');
2424
const assert = require('assert');
2525
const net = require('net');
2626

27-
const server1 = net.createServer(function(socket) {
28-
});
29-
const server2 = net.createServer(function(socket) {
30-
});
27+
const server1 = net.createServer(common.mustNotCall());
28+
const server2 = net.createServer(common.mustNotCall());
3129
server1.listen(0, common.mustCall(function() {
3230
server2.on('error', function(error) {
3331
assert.strictEqual(error.message.includes('EADDRINUSE'), true);

test/parallel/test-net-listen-close-server.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@
2323
const common = require('../common');
2424
const net = require('net');
2525

26-
const server = net.createServer(function(socket) {
27-
});
26+
const server = net.createServer(common.mustNotCall());
2827
server.listen(0, common.mustNotCall());
2928
server.on('error', common.mustNotCall());
3029
server.close();

test/parallel/test-net-listen-error.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
const common = require('../common');
2424
const net = require('net');
2525

26-
const server = net.createServer(function(socket) {
27-
});
26+
const server = net.createServer(common.mustNotCall());
2827
server.listen(1, '1.1.1.1', common.mustNotCall()); // EACCES or EADDRNOTAVAIL
2928
server.on('error', common.mustCall());

test/parallel/test-tls-close-error.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ const fixtures = require('../common/fixtures');
1111
const server = tls.createServer({
1212
key: fixtures.readKey('agent1-key.pem'),
1313
cert: fixtures.readKey('agent1-cert.pem')
14-
}, function(c) {
15-
}).listen(0, common.mustCall(function() {
14+
}, common.mustNotCall()).listen(0, common.mustCall(function() {
1615
const c = tls.connect(this.address().port, common.mustNotCall());
1716

1817
c.on('error', common.mustCall());

test/parallel/test-tls-handshake-error.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ const server = tls.createServer({
1414
key: fixtures.readKey('agent1-key.pem'),
1515
cert: fixtures.readKey('agent1-cert.pem'),
1616
rejectUnauthorized: true
17-
}, function(c) {
18-
}).listen(0, common.mustCall(function() {
17+
}, common.mustNotCall()).listen(0, common.mustCall(function() {
1918
assert.throws(() => {
2019
tls.connect({
2120
port: this.address().port,

0 commit comments

Comments
 (0)