Skip to content

Commit 127e703

Browse files
Matheus Marchinitargos
Matheus Marchini
authored andcommittedSep 7, 2018
deps: cherry-pick 09bca09 from upstream V8
Original commit message: [postmortem] add ScopeInfo and Context types The metadata introduced in this patch will be useful for postmortem tools to inspect Contexts and ScopeInfos (see nodejs/llnode#211). R=bmeurer@google.com, yangguo@google.com Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95 Reviewed-on: https://chromium-review.googlesource.com/1153858 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54768} Refs: v8/v8@09bca09 PR-URL: #22068 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 5bb985d commit 127e703

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed
 

‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929

3030
# Reset this number to 0 on major V8 upgrades.
3131
# Increment by one for each non-official patch applied to deps/v8.
32-
'v8_embedder_string': '-node.2',
32+
'v8_embedder_string': '-node.3',
3333

3434
# Enable disassembler for `--print-code` v8 options
3535
'v8_enable_disassembler': 1,

‎deps/v8/BUILD.gn

+1
Original file line numberDiff line numberDiff line change
@@ -852,6 +852,7 @@ action("postmortem-metadata") {
852852
"src/objects/js-regexp-string-iterator.h",
853853
"src/objects/map.h",
854854
"src/objects/map-inl.h",
855+
"src/objects/scope-info.h",
855856
"src/objects/script.h",
856857
"src/objects/script-inl.h",
857858
"src/objects/shared-function-info.h",

‎deps/v8/tools/gen-postmortem-metadata.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,9 @@
5858
{ 'name': 'APIObjectType', 'value': 'JS_API_OBJECT_TYPE' },
5959
{ 'name': 'SpecialAPIObjectType', 'value': 'JS_SPECIAL_API_OBJECT_TYPE' },
6060

61+
{ 'name': 'FirstContextType', 'value': 'FIRST_CONTEXT_TYPE' },
62+
{ 'name': 'LastContextType', 'value': 'LAST_CONTEXT_TYPE' },
63+
6164
{ 'name': 'IsNotStringMask', 'value': 'kIsNotStringMask' },
6265
{ 'name': 'StringTag', 'value': 'kStringTag' },
6366

@@ -282,7 +285,7 @@
282285
expected_classes = [
283286
'ConsString', 'FixedArray', 'HeapNumber', 'JSArray', 'JSFunction',
284287
'JSObject', 'JSRegExp', 'JSValue', 'Map', 'Oddball', 'Script',
285-
'SeqOneByteString', 'SharedFunctionInfo'
288+
'SeqOneByteString', 'SharedFunctionInfo', 'ScopeInfo'
286289
];
287290

288291

0 commit comments

Comments
 (0)