Skip to content

Commit 1285b90

Browse files
Trotttargos
authored andcommitted
doc: revise objections section of collaborator guide
The bold text is overused in this section. This change removes it. It also changes some wording: PR -> pull request, can -> may in a rare instance where "may" is the right choice in our docs, etc. (The recommendation to avoid "may" is because "may" implies permission rather than just ability. Yes, I'm probably the one that changed it from "may" in the first place.) PR-URL: #37525 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
1 parent bc86208 commit 1285b90

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

doc/guides/collaborator-guide.md

+11-11
Original file line numberDiff line numberDiff line change
@@ -154,21 +154,21 @@ requirements. If a pull request meets all requirements except the
154154

155155
#### Objections
156156

157-
**Collaborators can object to a pull request by using the "Request
158-
Changes" GitHub feature**. Dissent comments alone don't constitute an
159-
objection. **Any PR objection must include a clear reason for that objection,
160-
and the objector must remain responsive for further discussion towards
161-
consensus about the direction of the pull request**. Providing a set of
162-
actionable steps alongside the objection is recommended.
157+
Collaborators can object to a pull request by using the "Request
158+
Changes" GitHub feature. Dissent comments alone don't constitute an
159+
objection. Any pull request objection must include a clear reason for that
160+
objection, and the objector must remain responsive for further discussion
161+
towards consensus about the direction of the pull request. Where possible,
162+
provide a set of actionable steps alongside the objection.
163163

164164
If the objection is not clear to others, another collaborator can ask an
165165
objecting collaborator to explain their objection or to provide actionable
166-
steps to resolve the objection. **If the objector is unresponsive for seven
167-
days after a collaborator asks for clarification, another collaborator can
168-
dismiss the objection**.
166+
steps to resolve the objection. If the objector is unresponsive for seven
167+
days after a collaborator asks for clarification, a collaborator may
168+
dismiss the objection.
169169

170-
**Pull requests with outstanding objections must remain open until all
171-
objections are satisfied**. If reaching consensus is not possible, a
170+
Pull requests with outstanding objections must remain open until all
171+
objections are satisfied. If reaching consensus is not possible, a
172172
collaborator can escalate the issue to the TSC by pinging `@nodejs/tsc` and
173173
adding the `tsc-agenda` label to the issue.
174174

0 commit comments

Comments
 (0)