Skip to content

Commit 141aec9

Browse files
danbevtargos
authored andcommitted
crypto: add SET_INTEGER_CONSANT macro
This commit introduces a SET_INTEGER_CONSANT macro to reduce some code duplication in SecureContext::Initialize. PR-URL: #23687 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
1 parent 1521d89 commit 141aec9

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/node_crypto.cc

+10-10
Original file line numberDiff line numberDiff line change
@@ -355,16 +355,16 @@ void SecureContext::Initialize(Environment* env, Local<Object> target) {
355355
env->SetProtoMethodNoSideEffect(t, "getCertificate", GetCertificate<true>);
356356
env->SetProtoMethodNoSideEffect(t, "getIssuer", GetCertificate<false>);
357357

358-
t->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "kTicketKeyReturnIndex"),
359-
Integer::NewFromUnsigned(env->isolate(), kTicketKeyReturnIndex));
360-
t->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "kTicketKeyHMACIndex"),
361-
Integer::NewFromUnsigned(env->isolate(), kTicketKeyHMACIndex));
362-
t->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "kTicketKeyAESIndex"),
363-
Integer::NewFromUnsigned(env->isolate(), kTicketKeyAESIndex));
364-
t->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "kTicketKeyNameIndex"),
365-
Integer::NewFromUnsigned(env->isolate(), kTicketKeyNameIndex));
366-
t->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "kTicketKeyIVIndex"),
367-
Integer::NewFromUnsigned(env->isolate(), kTicketKeyIVIndex));
358+
#define SET_INTEGER_CONSTANTS(name, value) \
359+
t->Set(FIXED_ONE_BYTE_STRING(env->isolate(), name), \
360+
Integer::NewFromUnsigned(env->isolate(), value));
361+
SET_INTEGER_CONSTANTS("kTicketKeyReturnIndex", kTicketKeyReturnIndex);
362+
SET_INTEGER_CONSTANTS("kTicketKeyHMACIndex", kTicketKeyHMACIndex);
363+
SET_INTEGER_CONSTANTS("kTicketKeyAESIndex", kTicketKeyAESIndex);
364+
SET_INTEGER_CONSTANTS("kTicketKeyNameIndex", kTicketKeyNameIndex);
365+
SET_INTEGER_CONSTANTS("kTicketKeyIVIndex", kTicketKeyIVIndex);
366+
367+
#undef SET_INTEGER_CONSTANTS
368368

369369
Local<FunctionTemplate> ctx_getter_templ =
370370
FunctionTemplate::New(env->isolate(),

0 commit comments

Comments
 (0)