Skip to content

Commit 1722280

Browse files
timcostaMylesBorins
authored andcommitted
http,https: increase server headers timeout
Fixes: #24980 Refs: eb43bc04b1 PR-URL: #30071 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 2430dd8 commit 1722280

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

doc/api/http.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1107,7 +1107,7 @@ Stops the server from accepting new connections. See [`net.Server.close()`][].
11071107
added: v11.3.0
11081108
-->
11091109

1110-
* {number} **Default:** `40000`
1110+
* {number} **Default:** `60000`
11111111

11121112
Limit the amount of time the parser will wait to receive the complete HTTP
11131113
headers.

doc/api/https.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ See [`server.close()`][`http.close()`] from the HTTP module for details.
9494
added: v11.3.0
9595
-->
9696

97-
* {number} **Default:** `40000`
97+
* {number} **Default:** `60000`
9898

9999
See [`http.Server#headersTimeout`][].
100100

lib/_http_server.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ function Server(options, requestListener) {
348348
this.timeout = 0;
349349
this.keepAliveTimeout = 5000;
350350
this.maxHeadersCount = null;
351-
this.headersTimeout = 40 * 1000; // 40 seconds
351+
this.headersTimeout = 60 * 1000; // 60 seconds
352352
}
353353
ObjectSetPrototypeOf(Server.prototype, net.Server.prototype);
354354
ObjectSetPrototypeOf(Server, net.Server);

lib/https.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ function Server(opts, requestListener) {
7777
this.timeout = 0;
7878
this.keepAliveTimeout = 5000;
7979
this.maxHeadersCount = null;
80-
this.headersTimeout = 40 * 1000; // 40 seconds
80+
this.headersTimeout = 60 * 1000; // 60 seconds
8181
}
8282
ObjectSetPrototypeOf(Server.prototype, tls.Server.prototype);
8383
ObjectSetPrototypeOf(Server, tls.Server);

test/parallel/test-http-slow-headers.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ const headers =
1717
const server = createServer(common.mustNotCall());
1818
let sendCharEvery = 1000;
1919

20-
// 40 seconds is the default
21-
assert.strictEqual(server.headersTimeout, 40 * 1000);
20+
// 60 seconds is the default
21+
assert.strictEqual(server.headersTimeout, 60 * 1000);
2222

2323
// Pass a REAL env variable to shortening up the default
2424
// value which is 40s otherwise this is useful for manual

test/parallel/test-https-slow-headers.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ const server = createServer({
2727

2828
let sendCharEvery = 1000;
2929

30-
// 40 seconds is the default
31-
assert.strictEqual(server.headersTimeout, 40 * 1000);
30+
// 60 seconds is the default
31+
assert.strictEqual(server.headersTimeout, 60 * 1000);
3232

3333
// Pass a REAL env variable to shortening up the default
3434
// value which is 40s otherwise

0 commit comments

Comments
 (0)