Skip to content

Commit 18179f8

Browse files
cjihrigtargos
authored andcommitted
dns: remove Resolver#cancel() from promises API
Because reasons. PR-URL: #21264 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent aa864ba commit 18179f8

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

doc/api/dns.md

-8
Original file line numberDiff line numberDiff line change
@@ -622,14 +622,6 @@ The following methods from the `dnsPromises` API are available:
622622
* [`resolver.resolveTxt()`][`dnsPromises.resolveTxt()`]
623623
* [`resolver.reverse()`][`dnsPromises.reverse()`]
624624

625-
#### resolver.cancel()
626-
<!-- YAML
627-
added: REPLACEME
628-
-->
629-
630-
Cancel all outstanding DNS queries made by this resolver. The corresponding
631-
`Promise`s will be rejected with an error with code `ECANCELLED`.
632-
633625
### dnsPromises.getServers()
634626
<!-- YAML
635627
added: REPLACEME

lib/internal/dns/promises.js

-1
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,6 @@ class Resolver {
212212
}
213213
}
214214

215-
Resolver.prototype.cancel = CallbackResolver.prototype.cancel;
216215
Resolver.prototype.getServers = CallbackResolver.prototype.getServers;
217216
Resolver.prototype.setServers = CallbackResolver.prototype.setServers;
218217
Resolver.prototype.resolveAny = resolveMap.ANY = resolver('queryAny');

0 commit comments

Comments
 (0)