Skip to content

Commit 19984ad

Browse files
alexkozytargos
authored andcommitted
test: fix inspector tests after V8 upgrade
V8 improved break locations for the node --inspect-brk -e case. PR-URL: #21983 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent e6cdf24 commit 19984ad

6 files changed

+6
-7
lines changed

test/sequential/test-inspector-async-hook-setup-at-inspect-brk.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ setTimeout(() => {
1414
`;
1515

1616
async function skipBreakpointAtStart(session) {
17-
await session.waitForBreakOnLine(0, '[eval]');
17+
await session.waitForBreakOnLine(3, '[eval]');
1818
await session.send({ 'method': 'Debugger.resume' });
1919
}
2020

test/sequential/test-inspector-async-stack-traces-promise-then.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ async function runTests() {
3131
{ 'method': 'Runtime.runIfWaitingForDebugger' }
3232
]);
3333

34-
await session.waitForBreakOnLine(0, '[eval]');
34+
await session.waitForBreakOnLine(2, '[eval]');
3535
await session.send({ 'method': 'Debugger.resume' });
3636

3737
console.error('[test] Waiting for break1');

test/sequential/test-inspector-async-stack-traces-set-interval.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const script = 'setInterval(() => { debugger; }, 50);';
1010

1111
async function skipFirstBreakpoint(session) {
1212
console.log('[test]', 'Skipping the first breakpoint in the eval script');
13-
await session.waitForBreakOnLine(0, '[eval]');
13+
await session.waitForBreakOnLine(2, '[eval]');
1414
await session.send({ 'method': 'Debugger.resume' });
1515
}
1616

test/sequential/test-inspector-break-e.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Flags: --expose-internals
22
'use strict';
33
const common = require('../common');
4-
54
common.skipIfInspectorDisabled();
65

76
const assert = require('assert');
@@ -15,7 +14,7 @@ async function runTests() {
1514
{ 'method': 'Debugger.enable' },
1615
{ 'method': 'Runtime.runIfWaitingForDebugger' }
1716
]);
18-
await session.waitForBreakOnLine(0, '[eval]');
17+
await session.waitForBreakOnLine(2, '[eval]');
1918
await session.runToCompletion();
2019
assert.strictEqual(0, (await instance.expectShutdown()).exitCode);
2120
}

test/sequential/test-inspector-exception.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ async function testBreakpointOnStart(session) {
2929
];
3030

3131
await session.send(commands);
32-
await session.waitForBreakOnLine(0, script);
32+
await session.waitForBreakOnLine(21, script);
3333
}
3434

3535

test/sequential/test-inspector-scriptparsed-context.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ async function runTests() {
5151
{ 'method': 'Debugger.enable' },
5252
{ 'method': 'Runtime.runIfWaitingForDebugger' }
5353
]);
54-
await session.waitForBreakOnLine(0, '[eval]');
54+
await session.waitForBreakOnLine(4, '[eval]');
5555

5656
await session.send({ 'method': 'Runtime.enable' });
5757
await getContext(session);

0 commit comments

Comments
 (0)