Skip to content

Commit 19a983c

Browse files
richardlauMylesBorins
authored andcommitted
build: make linter failures fail test-doc target
Linter failures in the `test-doc` make target were not failing the build if the subsequent `doctools` test passed as its exit code wasn't being preserved. Make the `lint` target a dependency of `test-doc` so that it is outside of the `node_use_openssl` guard -- its own dependencies have their own guards where necessary and the targets that don't require an available node (e.g. the C++ linters) will be allowed to run. PR-URL: #30012 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
1 parent ed80c23 commit 19a983c

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

Makefile

+1-2
Original file line numberDiff line numberDiff line change
@@ -592,11 +592,10 @@ test-hash-seed: all
592592
$(NODE) test/pummel/test-hash-seed.js
593593

594594
.PHONY: test-doc
595-
test-doc: doc-only ## Builds, lints, and verifies the docs.
595+
test-doc: doc-only lint ## Builds, lints, and verifies the docs.
596596
@if [ "$(shell $(node_use_openssl))" != "true" ]; then \
597597
echo "Skipping test-doc (no crypto)"; \
598598
else \
599-
$(MAKE) lint; \
600599
$(PYTHON) tools/test.py $(PARALLEL_ARGS) doctool; \
601600
fi
602601

0 commit comments

Comments
 (0)