Skip to content

Commit 19f67db

Browse files
joyeecheungRafaelGSS
authored andcommitted
bootstrap: remove unused global parameter in per-context scripts
PR-URL: #44472 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
1 parent 20e04c6 commit 19f67db

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

src/api/environment.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -691,7 +691,7 @@ Maybe<bool> InitializePrimordials(Local<Context> context) {
691691
for (const char** module = context_files; *module != nullptr; module++) {
692692
// Arguments must match the parameters specified in
693693
// BuiltinLoader::LookupAndCompile().
694-
Local<Value> arguments[] = {context->Global(), exports, primordials};
694+
Local<Value> arguments[] = {exports, primordials};
695695
MaybeLocal<Function> maybe_fn =
696696
builtins::BuiltinLoader::LookupAndCompile(context, *module, nullptr);
697697
Local<Function> fn;

src/node_builtins.cc

-1
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,6 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompile(
349349
strlen("internal/per_context/")) == 0) {
350350
// internal/per_context/*: global, exports, primordials
351351
parameters = {
352-
FIXED_ONE_BYTE_STRING(isolate, "global"),
353352
FIXED_ONE_BYTE_STRING(isolate, "exports"),
354353
FIXED_ONE_BYTE_STRING(isolate, "primordials"),
355354
};

0 commit comments

Comments
 (0)