Skip to content

Commit 1a808a4

Browse files
tniessenMylesBorins
authored andcommitted
src: check return value of ftell()
If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1) to the vector allocator and fread(). Refs: #46463 PR-URL: #46495 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
1 parent f72f643 commit 1a808a4

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/node_snapshotable.cc

+1
Original file line numberDiff line numberDiff line change
@@ -877,6 +877,7 @@ bool SnapshotData::FromBlob(SnapshotData* out, FILE* in) {
877877
int err = fseek(in, 0, SEEK_END);
878878
CHECK_EQ(err, 0);
879879
size_t size = ftell(in);
880+
CHECK_NE(size, static_cast<size_t>(-1L));
880881
err = fseek(in, 0, SEEK_SET);
881882
CHECK_EQ(err, 0);
882883

0 commit comments

Comments
 (0)