Skip to content

Commit 1b45534

Browse files
Trotttargos
authored andcommitted
report: remove unnecessary return in setters
Barring shenanigans like Object.getOwnPropertyDescriptor(), return values from a setter function will always be inaccessible. Remove the `return` statements as they can be misleading, suggesting that the return value is accessible and perhaps used somewhere. PR-URL: #26614 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 3b471db commit 1b45534

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

lib/internal/process/report.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,14 @@ const report = {
3434
},
3535
set directory(dir) {
3636
validateString(dir, 'directory');
37-
return nr.setDirectory(dir);
37+
nr.setDirectory(dir);
3838
},
3939
get filename() {
4040
return nr.getFilename();
4141
},
4242
set filename(name) {
4343
validateString(name, 'filename');
44-
return nr.setFilename(name);
44+
nr.setFilename(name);
4545
},
4646
get signal() {
4747
return nr.getSignal();
@@ -51,7 +51,7 @@ const report = {
5151
convertToValidSignal(sig); // Validate that the signal is recognized.
5252
removeSignalHandler();
5353
addSignalHandler(sig);
54-
return nr.setSignal(sig);
54+
nr.setSignal(sig);
5555
},
5656
get reportOnFatalError() {
5757
return nr.shouldReportOnFatalError();
@@ -60,7 +60,7 @@ const report = {
6060
if (typeof trigger !== 'boolean')
6161
throw new ERR_INVALID_ARG_TYPE('trigger', 'boolean', trigger);
6262

63-
return nr.setReportOnFatalError(trigger);
63+
nr.setReportOnFatalError(trigger);
6464
},
6565
get reportOnSignal() {
6666
return nr.shouldReportOnSignal();
@@ -80,7 +80,7 @@ const report = {
8080
if (typeof trigger !== 'boolean')
8181
throw new ERR_INVALID_ARG_TYPE('trigger', 'boolean', trigger);
8282

83-
return nr.setReportOnUncaughtException(trigger);
83+
nr.setReportOnUncaughtException(trigger);
8484
}
8585
};
8686

0 commit comments

Comments
 (0)