lib: make lowerProto scope more clear

gengjiawen · targos · commit 1c1305dbc1a9 · 2019-03-27T21:58:57.000+01:00
PR-URL: #26562 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/url.js b/lib/url.js
@@ -249,10 +249,11 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
     }
   }
 
-  var proto = protocolPattern.exec(rest);
+  let proto = protocolPattern.exec(rest);
+  let lowerProto;
   if (proto) {
     proto = proto[0];
-    var lowerProto = proto.toLowerCase();
+    lowerProto = proto.toLowerCase();
     this.protocol = lowerProto;
     rest = rest.slice(proto.length);
   }

Original file line number	Diff line number	Diff line change
`@@ -249,10 +249,11 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {`
`249`	`249`	`}`
`250`	`250`	`}`
`251`	`251`
`252`		`- var proto = protocolPattern.exec(rest);`
	`252`	`+ let proto = protocolPattern.exec(rest);`
	`253`	`+ let lowerProto;`
`253`	`254`	`if (proto) {`
`254`	`255`	`proto = proto[0];`
`255`		`- var lowerProto = proto.toLowerCase();`
	`256`	`+ lowerProto = proto.toLowerCase();`
`256`	`257`	`this.protocol = lowerProto;`
`257`	`258`	`rest = rest.slice(proto.length);`
`258`	`259`	`}`