Skip to content

Commit 1cdccbc

Browse files
tniessenRafaelGSS
authored andcommitted
tls: remove SecureContext setFreeListLength
This function was introduced in 2684c90 as an internal helper function. The C++ implementation became a no-op in a57e2f2 when building against OpenSSL 1.1.0 (instead of OpenSSL 1.0.2), and eventually became a no-op in all supported OpenSSL versions in 970ce14. Finally, eb20447 removed the only call site of setFreeListLength (which was already a no-op at that point). Refs: #1529 Refs: #10859 Refs: #19794 Refs: #38116 PR-URL: #44300 Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 7039916 commit 1cdccbc

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

src/crypto/crypto_context.cc

-5
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,6 @@ Local<FunctionTemplate> SecureContext::GetConstructorTemplate(
285285
SetProtoMethod(isolate, tmpl, "close", Close);
286286
SetProtoMethod(isolate, tmpl, "loadPKCS12", LoadPKCS12);
287287
SetProtoMethod(isolate, tmpl, "setTicketKeys", SetTicketKeys);
288-
SetProtoMethod(isolate, tmpl, "setFreeListLength", SetFreeListLength);
289288
SetProtoMethod(
290289
isolate, tmpl, "enableTicketKeyCallback", EnableTicketKeyCallback);
291290

@@ -365,7 +364,6 @@ void SecureContext::RegisterExternalReferences(
365364
registry->Register(Close);
366365
registry->Register(LoadPKCS12);
367366
registry->Register(SetTicketKeys);
368-
registry->Register(SetFreeListLength);
369367
registry->Register(EnableTicketKeyCallback);
370368
registry->Register(GetTicketKeys);
371369
registry->Register(GetCertificate<true>);
@@ -1121,9 +1119,6 @@ void SecureContext::SetTicketKeys(const FunctionCallbackInfo<Value>& args) {
11211119
#endif // !def(OPENSSL_NO_TLSEXT) && def(SSL_CTX_get_tlsext_ticket_keys)
11221120
}
11231121

1124-
void SecureContext::SetFreeListLength(const FunctionCallbackInfo<Value>& args) {
1125-
}
1126-
11271122
// Currently, EnableTicketKeyCallback and TicketKeyCallback are only present for
11281123
// the regression test in test/parallel/test-https-resume-after-renew.js.
11291124
void SecureContext::EnableTicketKeyCallback(

src/crypto/crypto_context.h

-2
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,6 @@ class SecureContext final : public BaseObject {
100100
#endif // !OPENSSL_NO_ENGINE
101101
static void GetTicketKeys(const v8::FunctionCallbackInfo<v8::Value>& args);
102102
static void SetTicketKeys(const v8::FunctionCallbackInfo<v8::Value>& args);
103-
static void SetFreeListLength(
104-
const v8::FunctionCallbackInfo<v8::Value>& args);
105103
static void EnableTicketKeyCallback(
106104
const v8::FunctionCallbackInfo<v8::Value>& args);
107105
static void CtxGetter(const v8::FunctionCallbackInfo<v8::Value>& info);

0 commit comments

Comments
 (0)