Skip to content

Commit 1e09629

Browse files
BridgeARBethGriggs
authored andcommitted
doc: fix author-ready conflict
The onboarding docs still contained an outdated description of the `author-ready` label. Now it references the main description to prevent any future conflicts. PR-URL: #25015 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent d366676 commit 1e09629

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

doc/onboarding.md

+2-5
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,7 @@ onboarding session.
9696
`semver-major` label
9797
* When adding a `semver-*` label, add a comment explaining why you're adding
9898
it. Do it right away so you don't forget!
99-
* Please add the `author-ready` label for PRs where:
100-
* the CI has been started (not necessarily finished),
101-
* no outstanding review comments exist and
102-
* at least two Collaborators approved the PR (one Collaborator approval is
103-
enough if the pull request has been open for more than 7 days).
99+
* Please add the [`author-ready`][] label for PRs, if applicable.
104100

105101
* See [Who to CC in the issue tracker][who-to-cc].
106102
* This will come more naturally over time
@@ -245,6 +241,7 @@ needs to be pointed out separately during the onboarding.
245241
the [summit](https://github.com/nodejs/summit) repository for details.
246242

247243
[Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md
244+
[`author-ready`]: https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#author-ready-pull-requests
248245
[`core-validate-commit`]: https://github.com/nodejs/core-validate-commit
249246
[`git-node`]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md
250247
[`node-core-utils`]: https://github.com/nodejs/node-core-utils

0 commit comments

Comments
 (0)