Skip to content

Commit 1eac1d7

Browse files
BridgeARMylesBorins
authored andcommittedMar 21, 2018
test: minor refactoring
Add punctuation and comments about code that should not throw. Also remove a obsolete test and refactor some tests. Backport-PR-URL: #19244 PR-URL: #18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent 574d061 commit 1eac1d7

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+163
-204
lines changed
 

‎test/addons/symlinked-module/test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,5 @@ const sub = require('./submodule');
3030
const mod = require(path.join(i, 'binding.node'));
3131
assert.notStrictEqual(mod, null);
3232
assert.strictEqual(mod.hello(), 'world');
33-
sub.test(i);
33+
sub.test(i); // Should not throw.
3434
});

‎test/internet/test-dns.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -579,11 +579,8 @@ process.on('exit', function() {
579579
assert.ok(getaddrinfoCallbackCalled);
580580
});
581581

582-
582+
// Should not throw.
583583
dns.lookup(addresses.INET6_HOST, 6, common.mustCall());
584-
585584
dns.lookup(addresses.INET_HOST, {}, common.mustCall());
586-
587585
dns.lookupService('0.0.0.0', '0', common.mustCall());
588-
589586
dns.lookupService('0.0.0.0', 0, common.mustCall());

0 commit comments

Comments
 (0)