Skip to content

Commit 206c668

Browse files
cjihrigmarco-ippolito
authored andcommitted
test_runner: remove plan option from run()
This commit removes the plan option to run(). I believe it was added by mistake. It is not documented, untested, and a test plan does not make sense in the context of run(). This commit also fixes a minor formatting issue in a related fixture. Refs: #52860 PR-URL: #53834 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
1 parent 8660d48 commit 206c668

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

lib/internal/test_runner/runner.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -524,7 +524,6 @@ function run(options) {
524524
watch,
525525
setup,
526526
only,
527-
plan,
528527
} = options;
529528

530529
if (files != null) {
@@ -577,7 +576,7 @@ function run(options) {
577576
});
578577
}
579578

580-
const root = createTestTree({ __proto__: null, concurrency, timeout, signal, plan });
579+
const root = createTestTree({ __proto__: null, concurrency, timeout, signal });
581580
root.harness.shouldColorizeTestFiles ||= shouldColorizeTestFiles(root);
582581

583582
if (process.env.NODE_TEST_CONTEXT !== undefined) {

test/fixtures/test-runner/output/test-runner-plan.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,6 @@ test('planning with streams', (t, done) => {
7474
});
7575

7676
stream.on('end', () => {
77-
done();
77+
done();
7878
});
7979
})

0 commit comments

Comments
 (0)