Skip to content

Commit 2130891

Browse files
committed
deps: disable trap handler for Windows cross-compiler
`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: #40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent e678b6c commit 2130891

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.3',
39+
'v8_embedder_string': '-node.4',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/trap-handler/trap-handler.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ namespace trap_handler {
2727
#define V8_TRAP_HANDLER_SUPPORTED true
2828
// Arm64 simulator on x64 on Linux, Mac, or Windows.
2929
#elif V8_TARGET_ARCH_ARM64 && V8_HOST_ARCH_X64 && \
30-
(V8_OS_LINUX || V8_OS_DARWIN || V8_OS_WIN)
30+
(V8_OS_LINUX || V8_OS_DARWIN)
3131
#define V8_TRAP_HANDLER_VIA_SIMULATOR
3232
#define V8_TRAP_HANDLER_SUPPORTED true
3333
// Everything else is unsupported.

0 commit comments

Comments
 (0)