Skip to content

Commit 2149acd

Browse files
F3n67utargos
authored andcommitted
dns: make promise API fully constructed from lib/internal/dns/promises
PR-URL: #43227 Refs: #43198 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
1 parent 9bd13bb commit 2149acd

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

lib/dns.js

-2
Original file line numberDiff line numberDiff line change
@@ -439,8 +439,6 @@ ObjectDefineProperties(module.exports, {
439439
get() {
440440
if (promises === null) {
441441
promises = require('internal/dns/promises');
442-
promises.setServers = defaultResolverSetServers;
443-
promises.setDefaultResultOrder = setDefaultResultOrder;
444442
}
445443
return promises;
446444
}

lib/dns/promises.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
'use strict';
22

3-
const dnsPromises = require('internal/dns/promises');
4-
dnsPromises.setServers = require('dns').setServers;
5-
module.exports = dnsPromises;
3+
module.exports = require('internal/dns/promises');

lib/internal/dns/promises.js

+11
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ const {
1717
emitInvalidHostnameWarning,
1818
getDefaultVerbatim,
1919
errorCodes: dnsErrorCodes,
20+
setDefaultResultOrder,
21+
setDefaultResolver,
2022
} = require('internal/dns/utils');
2123
const {
2224
NODATA,
@@ -349,11 +351,20 @@ Resolver.prototype.resolve = function resolve(hostname, rrtype) {
349351
return ReflectApply(resolver, this, [hostname]);
350352
};
351353

354+
function defaultResolverSetServers(servers) {
355+
const resolver = new Resolver();
356+
357+
resolver.setServers(servers);
358+
setDefaultResolver(resolver);
359+
bindDefaultResolver(module.exports, Resolver.prototype);
360+
}
352361

353362
module.exports = {
354363
lookup,
355364
lookupService,
356365
Resolver,
366+
setDefaultResultOrder,
367+
setServers: defaultResolverSetServers,
357368

358369
// ERROR CODES
359370
NODATA,

0 commit comments

Comments
 (0)