Skip to content

Commit 22c7f91

Browse files
bnoordhuisMylesBorins
authored andcommitted
src: remove superfluous HandleScope
Accessors implicitly run inside a HandleScope, UDPWrap::GetFD() doesn't need to create one explicitly. PR-URL: #16482 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 0f7ee26 commit 22c7f91

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/udp_wrap.cc

-1
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,6 @@ void UDPWrap::New(const FunctionCallbackInfo<Value>& args) {
137137
void UDPWrap::GetFD(Local<String>, const PropertyCallbackInfo<Value>& args) {
138138
int fd = UV_EBADF;
139139
#if !defined(_WIN32)
140-
HandleScope scope(args.GetIsolate());
141140
UDPWrap* wrap = Unwrap<UDPWrap>(args.Holder());
142141
if (wrap != nullptr)
143142
uv_fileno(reinterpret_cast<uv_handle_t*>(&wrap->handle_), &fd);

0 commit comments

Comments
 (0)