Skip to content

Commit 2405922

Browse files
committed
quic: fixup session ticket app data todo comments
PR-URL: #34741 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent c17eaa3 commit 2405922

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

src/quic/node_quic_session.h

+8-11
Original file line numberDiff line numberDiff line change
@@ -616,20 +616,17 @@ class QuicApplication : public MemoryRetainer,
616616

617617
virtual void ResumeStream(int64_t stream_id) {}
618618

619-
virtual void SetSessionTicketAppData(const SessionTicketAppData& app_data) {
620-
// TODO(@jasnell): Different QUIC applications may wish to set some
621-
// application data in the session ticket (e.g. http/3 would set
622-
// server settings in the application data). For now, doing nothing
623-
// as I'm just adding the basic mechanism.
624-
}
625-
619+
// Different QUIC applications may set some application data in
620+
// the session ticket (e.g. http/3 would set server settings in the
621+
// application data). By default, there's nothing to set.
622+
virtual void SetSessionTicketAppData(const SessionTicketAppData& app_data) {}
623+
624+
// Different QUIC applications may set some application data in
625+
// the session ticket (e.g. http/3 would set server settings in the
626+
// application data). By default, there's nothing to get.
626627
virtual SessionTicketAppData::Status GetSessionTicketAppData(
627628
const SessionTicketAppData& app_data,
628629
SessionTicketAppData::Flag flag) {
629-
// TODO(@jasnell): Different QUIC application may wish to set some
630-
// application data in the session ticket (e.g. http/3 would set
631-
// server settings in the application data). For now, doing nothing
632-
// as I'm just adding the basic mechanism.
633630
return flag == SessionTicketAppData::Flag::STATUS_RENEW ?
634631
SessionTicketAppData::Status::TICKET_USE_RENEW :
635632
SessionTicketAppData::Status::TICKET_USE;

0 commit comments

Comments
 (0)