Skip to content

Commit 246a94f

Browse files
oryanmoshetargos
authored andcommitted
test: see value of "hadError" in tls test
The existing implementation created a state that if the assert failed we got an error message without the values of hadError. Removed the default error message and added a comment explaining the assert. PR-URL: #22069 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent a40ee21 commit 246a94f

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

test/parallel/test-tls-hello-parser-failure.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ const server = tls.createServer(options, function(c) {
6060
}));
6161

6262
client.on('close', common.mustCall(function(hadError) {
63-
assert.strictEqual(hadError, true, 'Client never errored');
63+
// Confirm that client errored
64+
assert.strictEqual(hadError, true);
6465
}));
6566
}));

0 commit comments

Comments
 (0)