Skip to content

Commit 263cad2

Browse files
danbevMylesBorins
authored andcommitted
build: add MAKEFLAGS="-j1" to node-gyp
Currently, when building the addons the following warning is displayed: make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. Adding the MAKEFLAGS="-j1" to avoid the warning. Also updated the log message to say that it is building the addon and not running the test as I think that is more accurate. PR-URL: #9450 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 40bf0ee commit 263cad2

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

Makefile

+4-3
Original file line numberDiff line numberDiff line change
@@ -163,9 +163,10 @@ test/addons/.buildstamp: config.gypi \
163163
test/addons/.docbuildstamp
164164
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
165165
# embedded addons have been generated from the documentation.
166-
for dirname in test/addons/*/; do \
167-
echo "\nRunning addons test $$PWD/$$dirname" ; \
168-
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp --loglevel=$(LOGLEVEL) rebuild \
166+
@for dirname in test/addons/*/; do \
167+
echo "\nBuilding addon $$PWD/$$dirname" ; \
168+
env MAKEFLAGS="-j1" $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp \
169+
--loglevel=$(LOGLEVEL) rebuild \
169170
--python="$(PYTHON)" \
170171
--directory="$$PWD/$$dirname" \
171172
--nodedir="$$PWD" || exit 1 ; \

0 commit comments

Comments
 (0)