Skip to content

Commit 267b0b5

Browse files
committedSep 7, 2018
tools: fix compilation after V8 upgrade
V8 now requires ICU's regular expressions. PR-URL: #21983 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent 90ae4bd commit 267b0b5

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed
 

‎tools/icu/icu-generic.gyp

-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
'direct_dependent_settings': {
3333
'defines': [
3434
'UCONFIG_NO_SERVICE=1',
35-
'UCONFIG_NO_REGULAR_EXPRESSIONS=1',
3635
'U_ENABLE_DYLOAD=0',
3736
'U_STATIC_IMPLEMENTATION=1',
3837
'U_HAVE_STD_STRING=1',

0 commit comments

Comments
 (0)