Skip to content

Commit 281023b

Browse files
addaleaxMylesBorins
authored andcommitted
doc: exempt test/doc only changes from 48-hr rule
If a change affects only specific parts of the tests and or documentation, and in particular not of the runtime code itself, it should often be okay to land it early. The primary goal of the 48-hour rule is to ensure that people who are invested in certain parts of Node have a reasonable chance to weigh in based on their usage of Node; if the API is not touched in a change, that is arguably much less of an issue. In particular, this: - Should help avoid excessive nitpicking. - Helps newcomers, since their first PRs often touch only those areas and a direct success is very motivating. - Helps with the amount of pull requests created by events such a Code & Learn. PR-URL: #16135 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent c4db4e4 commit 281023b

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

COLLABORATOR_GUIDE.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@ from other Collaborators. Leave at least 48 hours during the week and
6464
72 hours over weekends to account for international time differences
6565
and work schedules. Trivial changes (e.g. those which fix minor bugs
6666
or improve performance without affecting API or causing other
67-
wide-reaching impact) may be landed after a shorter delay.
67+
wide-reaching impact), and focused changes that affect only documentation
68+
and/or the test suite, may be landed after a shorter delay if they have
69+
multiple approvals.
6870

6971
For non-breaking changes, if there is no disagreement amongst
7072
Collaborators, a pull request may be landed given appropriate review.

0 commit comments

Comments
 (0)