Skip to content

Commit 28b7bf0

Browse files
danbevevanlucas
authored andcommitted
deps: cherry-pick b8331cc030 from upstream V8
Original commit message: I believe the paths to the V8 include headers are incorrect. The paths to other sources seem to be relative to the parent directory. When building Node.js I get the following warning on Windows: Warning: Missing input files: deps\v8\src\..\..\include\v8-inspector-protocol.h deps\v8\src\..\..\include\v8-inspector.h This commit updates the two include paths. Bug: Change-Id: I51a057abba61e294e7811ba69db03e283b0bdc3f Reviewed-on: https://chromium-review.googlesource.com/743981 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49121} This commit also increments the v8_embedder_string version. PR-URL: #16900 Fixes: #16614 Refs: v8/v8@b8331cc Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent 8611e3b commit 28b7bf0

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
# Reset this number to 0 on major V8 upgrades.
2929
# Increment by one for each non-official patch applied to deps/v8.
30-
'v8_embedder_string': '-node.8',
30+
'v8_embedder_string': '-node.9',
3131

3232
# Enable disassembler for `--print-code` v8 options
3333
'v8_enable_disassembler': 1,

deps/v8/src/inspector/inspector.gypi

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@
3131
'inspector_all_sources': [
3232
'<@(inspector_generated_sources)',
3333
'<(inspector_generated_injected_script)',
34-
'../../include/v8-inspector.h',
35-
'../../include/v8-inspector-protocol.h',
34+
'../include/v8-inspector.h',
35+
'../include/v8-inspector-protocol.h',
3636
'inspector/injected-script.cc',
3737
'inspector/injected-script.h',
3838
'inspector/inspected-context.cc',

0 commit comments

Comments
 (0)